Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and contribution guidelines #45

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nCastle1
Copy link
Contributor

@nCastle1 nCastle1 commented Jan 8, 2022

This new format is intended to tie the various aspects of the .NET SDK together into a cohesive whole. Additionally, these changes make the landing pages more visual and accessible, with a goal of better showcasing our excellent SDK resources.

Also, this change updates the contribution guidelines doc to match the formatting in other repos.

This new format is intended to tie the various aspects of the .NET SDK together into a cohesive whole. Additionally, these changes make the landing pages more visual and accessible, with a goal of better showcasing our excellent SDK resources.

Also, this change updates the contribution guidelines doc to match the formatting in other repos.
Copy link

@ThadT ThadT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nCastle1, this looks great. Just a couple small suggestions for you to consider.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mbranscomb
Copy link
Member

This is a great improvement. Consider applying some of the feedback from similar PRs in other repos where appropriate.

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mbranscomb mbranscomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nCastle1 Great improvement over the existing readme.

Made a a couple of comments/suggestions.

README.md Outdated Show resolved Hide resolved
nCastle1 and others added 4 commits January 28, 2022 14:24
Co-authored-by: Mike Branscomb <3381768+mbranscomb@users.noreply.github.com>
Co-authored-by: Mike Branscomb <3381768+mbranscomb@users.noreply.github.com>
@mbranscomb mbranscomb self-requested a review August 1, 2022 16:21
Copy link
Member

@mbranscomb mbranscomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nCastle1 Looks good.

@nCastle1 nCastle1 requested a review from dotMorten August 9, 2022 16:22
@nCastle1 nCastle1 changed the base branch from main to v200 October 21, 2022 19:56
@nCastle1 nCastle1 requested review from dotMorten and removed request for dotMorten October 21, 2022 19:58
Base automatically changed from v200 to main December 14, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants