append round evidence to decrypter worker payload #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twittner
reviewed
Jun 4, 2025
timeboost-sequencer/src/lib.rs
Outdated
Comment on lines
364
to
367
| round = payload.round(); | ||
| if payload.evidence().round() > evidence.round() { | ||
| evidence = payload.evidence().clone() | ||
| } |
There was a problem hiding this comment.
Maybe it makes sense to move this into the Ok(data) branch below so the values are only updated if the corresponding candidate list has been successfully decoded.
Once done, using a hypothetical Payload::into_evidence method would save a clone.
There was a problem hiding this comment.
good suggestion, done in a7404cc
twittner
reviewed
Jun 4, 2025
timeboost-sequencer/src/lib.rs
Outdated
| @@ -350,13 +356,19 @@ impl Task { | |||
| let mut candidates = Vec::new(); | |||
| while !actions.is_empty() { | |||
| let mut round = RoundNumber::genesis(); | |||
| let mut evidence = Evidence::Genesis; | |||
| let mut lists = Vec::new(); | |||
| while let Some(action) = actions.pop_front() { | |||
| match action { | |||
| Action::Deliver(payload) => { | |||
| round = payload.round(); | |||
There was a problem hiding this comment.
Can this update also be moved into the Ok(data) branch? I think we should either use all or none of the payload values.
There was a problem hiding this comment.
sounds good, done in 8a34dd4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://app.asana.com/1/1208976916964769/project/1209394409339229/task/1210279951025506
This PR:
Payload.evidencefieldorder_vertices(), data: payload + evidenceevidencetoIncluder::inclusion_list(&mut self, round, evidence, lists: Vec<CandidateList>) -> OutcomeInclusionList.evidencefieldinsert_shares,Committeeinfo for the evidence check later, this committee will be updated via Decrypter's request when we have dynamic committee (future PR)