Multiple committees #360
Draft
Multiple committees #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertices no longer contain just a round number, but a pair of round number and committee ID. This allows validation of certificates and signatures to select the right committee.
Require `DataSource::Data` to implement `HasTime` so that Sailfish can build a consensus timestamp based on the committed vertices of a round.
Closed
Buffer if committee is not known yet.
jparr721
reviewed
Jun 5, 2025
timeboost-sequencer/src/lib.rs
Outdated
| let rbc = Rbc::new(Overlay::new(net), rcf.with_metrics(rbc_metrics)); | ||
|
|
||
| let rbc = Rbc::new( | ||
| 5 * committee.size().get(), |
There was a problem hiding this comment.
A magic number. The exact capacity should not matter.
jparr721
reviewed
Jun 5, 2025
Track state of consensus instance and make sure that after handover has been initiated, no messages of later rounds are being processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair round numbers with committee IDs to allow selection of the right committee when verifying signatures and certificates.
Also require vertex payloads to have a timestamp which will be used to derive the consensus timestamp when a round is delivered.
A
CommitteeVecallows keeping multiple committees and indexing them by committee ID.