Parallelization optimizations#105
Merged
Merged
Conversation
bbuenz
reviewed
Dec 17, 2022
bbuenz
left a comment
bbuenz
left a comment
Contributor
There was a problem hiding this comment.
Are all these under the parallel feature flag?
Contributor
Author
Not yet. We can add parallel feature flag everywhere. The only drawback is that the code will be a little redundant. I can add a commit if we decide to make them under parallel flags. Btw, currently, we achieve 1-thread performance by command |
bbuenz
reviewed
Dec 19, 2022
bbuenz
reviewed
Dec 19, 2022
| res[i] = data[i << 1] + (data[(i << 1) + 1] - data[i << 1]) * point; | ||
| } | ||
| } | ||
| res.par_iter_mut().enumerate().for_each(|(i, x)| { |
Contributor
There was a problem hiding this comment.
Should we continue to make parallel dependent on nv?
bbuenz
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of optimizations on prover:
RcwithArc. (cherrypick from @bbuenz 's branch main...arcpariter)