Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for JDK 17 #886

Merged
merged 8 commits into from
Nov 15, 2022
Merged

Improve tests for JDK 17 #886

merged 8 commits into from
Nov 15, 2022

Conversation

theigl
Copy link
Collaborator

@theigl theigl commented Feb 21, 2022

This PR attempts to fix as many tests as possible when running under JDK17 without any add-opens arguments.

Most tests work without opening up modules now. Only one tests still fails:

  • SerializationCompatTest fails because of AtomicInteger.

We need custom serializers for Atomic* JDK classes to fix this.

…ializedLambda#readResolve` is not accessible
@theigl
Copy link
Collaborator Author

theigl commented Feb 21, 2022

I added a fall-back for lambda deserialization in f3cd2df.

@theigl
Copy link
Collaborator Author

theigl commented Feb 21, 2022

The only remaining issue is with AtomicInteger and we can't fix this without breaking backwards compatibility. We should add serializers for Atomic*, UUID, Pattern etc in Kryo 6.

@theigl theigl merged commit 7d90a4c into master Nov 15, 2022
@theigl theigl deleted the jdk17-tests branch November 15, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant