Use relatively safe max size of java array

[ravwojdyla]

See:

• https://stackoverflow.com/questions/3038392/do-java-arrays-have-a-maximum-size
• [BEAM-2334] Fix OutOfMemoryError apache/beam#3189

[isaki]

Is there a reason why the constants in Util aren't marked final? If the code relies on their mutability that is a significant threading issue. I know you are just following the model of what has been done before in that class, but I'm wondering if this should be fixed.

[ravwojdyla]

@isaki-x valid question. In the mean time I will fix this in the current PR. Thanks.

[magro]

As a constant it should probably follow naming conventions for constants?
Alternatively, this could be defined somewhere in the io package and be package private, with the advantage that the public api is not extended (but keeping it here is fine for me as well).

[isaki]

The issue here is that while you are certainly correct, the file being modified does not in fact utilize the standard (so it becomes a style issue: should the file be updated to match the standard or should it be left alone and made at least internally consistent?).

The line after the line the author added is:

static public boolean isAndroid = "Dalvik".equals(System.getProperty("java.vm.name"));

This should probably be changed to:

public static final boolean IS_ANDROID = "Dalvik".equals(System.getProperty("java.vm.name"));

... or something along those lines. Unless of course you intended for this to be modifiable... then you should probably have set/get and locks/synchronized access or make it an AtomicBoolean (or an AtomicBoolean abstracted by get/set so it can change later).

I do like the idea of minimal visibility and moving this to the IO package is probably the right call regardless of the naming standard and thread safety considerations I have raised.

[magro]

Oh yeah, you're right, I should have made this final - I don't think that I intended this to be modifiable (I really hope that nobody wants to do this) ;-)

[ravwojdyla]

@magro thanks for the review. Updated:

• use constant naming
• moved to package private in io

PTAL

[magro]

Thanks for the PR!