Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix growing ByteBufferOutput while writing varint (#464) #465

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Fix growing ByteBufferOutput while writing varint (#464) #465

merged 1 commit into from
Oct 6, 2016

Conversation

ahilsend
Copy link

@ahilsend ahilsend commented Oct 6, 2016

Growing the ByteBuffer while writing varInt or varLong will change the byte order first, and then perform the require.

If the ByteBuffer needs to grow the setBuffer will again change the ByteOrder, but this time the one set by the varInt method. Thus the final ByteOrder was incorrect. (see #464)

Growing the ByteBuffer while writing varInt or varLong will change the byte order first, and then perform the require.

If the ByteBuffer needs to grow the setBuffer will again change the ByteOrder, but this time the one set by the varInt method. Thus the final ByteOrder was incorrect.
@romix
Copy link
Collaborator

romix commented Oct 6, 2016

Looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants