-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forward compatibility to TaggedFieldSerializer #352
Comments
+1 |
Pull requests welcome! :-) Am 01.10.2015 21:41 schrieb "Pablo Marcos" notifications@github.com:
|
Great! I'll work on it and send it! |
Hi, I have just sent a pull request. Could you please help review it? |
Would be great to have this feature soon 👍 |
Add forward compatibility to TaggedFieldSerializer in issue #352.
Resolved with #365 |
@levyfan Could you explain why the fields need to be written in tag value order? (Maybe just to make reading faster?) And I don't see where or how the unknown bytes of the future tagged field are skipped in the Input. Thanks. |
Hello, how do you do?
I was wondering why TaggedFieldSerializer doesn't have a configuration like jackson's "FAIL_ON_UNKNOWN_PROPERTIES". It seems that it would be an easy way to add forward compatibility on demand, and I think the only piece of code that would need to be changed is:
This would give us more flexibility, specially when 2 different apps are used to serialize and deserialize the object.
It would also allow to avoid having to declare deprecated fields, although this could be a dangerous practice, leading to forgetting and reusing a tag.
Thank you very much!
The text was updated successfully, but these errors were encountered: