fix(ante): prevent panic when building error message of fee which overflow int64 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorTrustyDev
added
the
enhancement
VictorEscan
approved these changes
Jan 8, 2024
VictorTrustyDev
deleted the
fix/prevent-int64-overflow-in-fee-ante-handle
branch
VictorTrustyDev
restored the
fix/prevent-int64-overflow-in-fee-ante-handle
branch
VictorTrustyDev
deleted the
fix/prevent-int64-overflow-in-fee-ante-handle
branch
VictorTrustyDev
added a commit
that referenced
this pull request
Jan 8, 2024
…-ante-handle-backport-59 fix: prevent panic when building error message of fee which overflow int64 (backport #59)
VictorTrustyDev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to patch a potential panic where error message constructs using two variables that possible larger than
math.MaxInt64thus causing panic.2 testcases was added to make sure neither of them, when overflow of int64, would causes panic