Skip to content

fix(evm): re-calculate base-fee & adjust gas-meter reset behavior when trace transaction/block #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VictorTrustyDev merged 6 commits into from
Dec 30, 2023
Merged

fix(evm): re-calculate base-fee & adjust gas-meter reset behavior when trace transaction/block #5

VictorTrustyDev merged 6 commits into from
Dec 30, 2023

Conversation

@VictorTrustyDev
Copy link

@VictorTrustyDev VictorTrustyDev commented Dec 30, 2023 •
edited by VictorEscan
Loading

Refer #2

Describe of issues:

  • Gas meter staking for every predecessor during tracing tx that caused out-of-gas sometime when tracing
  • When trace tx/block, base fee from previous block height is used, that is incorrect

Solution applied:

  • Reset gas meter before every tx trace
  • Calculate base-fee (for using context block) at early of trace request and use it.

@VictorTrustyDev VictorTrustyDev added the enhancement Enhancement / bug-fixes or re-work on old feature label Dec 30, 2023
@VictorTrustyDev VictorTrustyDev self-assigned this Dec 30, 2023
@VictorTrustyDev VictorTrustyDev linked an issue Dec 30, 2023 that may be closed by this pull request
Problem: patch known issue in v12 #2
Closed
@VictorTrustyDev VictorTrustyDev merged commit a5c6a1d into main Dec 30, 2023
@VictorTrustyDev VictorTrustyDev deleted the fix/correct-inconsistent-base-fee-and-fix-gas-meter-stacking-when-tracing-tx branch December 30, 2023 17:53
This was referenced Dec 30, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VictorEscan VictorEscan VictorEscan approved these changes

Assignees

@VictorTrustyDev VictorTrustyDev

Labels

enhancement Enhancement / bug-fixes or re-work on old feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem: patch known issue in v12

3 participants

@VictorTrustyDev @VictorEscan