imp(evm): consume all gas upon ApplyTransaction failure without VM error
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorTrustyDev
added
the
enhancement
VictorEscan
approved these changes
Jan 2, 2024
VictorTrustyDev
added a commit
that referenced
this pull request
Jan 2, 2024
…ssage-failure-backport-39 imp(evm): consume all gas upon `ApplyTransaction` failure without VM error (backport #39)
VictorTrustyDev
deleted the
imp/consume-all-gas-upon-apply-message-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to EIP-140
The opcode REVERT provides a way to stop execution and revert state changes, without consuming all provided gas.
That means, all the other failure will consume all gas.
By this PR, in
ApplyTransactionimplementation, by calling toApplyMessageWithConfig, if not error return by Evm, will consider as not-caused-by-REVERT-opcode therefor consume all gas of tx.