Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeClick is having the name parameter undefined #50

Closed
ishan28mkip opened this issue Apr 6, 2017 · 2 comments
Closed

NodeClick is having the name parameter undefined #50

ishan28mkip opened this issue Apr 6, 2017 · 2 comments
Assignees
Labels

Comments

@ishan28mkip
Copy link

nodeClick callback is getting the name parameter undefined, probably happened because of d3 version change, just need to change d.name to d.data.name when calling the callback. Will send a pr when free, also leaving a comment on the code if someone else is working on it.

@ErikGartner
Copy link
Owner

Thanks, you're absolutely right!
I'll merge your pr as fast as possible. :-)

@ErikGartner
Copy link
Owner

Thanks for the bug report @ishan28mkip. I had some spare time so I released a fix.
Let me know if you have any remaining problems :)

@ErikGartner ErikGartner self-assigned this Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants