-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename python tool to ipython for better tooluse format adherence #361
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 955afab in 13 seconds
More details
- Looked at
44
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. gptme/tools/__init__.py:79
- Draft comment:
The import statement should be updated to reflect the tool name change from 'python' to 'ipython'. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_s6YCea8pKD6G18RS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
955afab
to
113fa58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 113fa58 in 19 seconds
More details
- Looked at
52
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_v7TPTFwBBZoHjjRW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Attempt at improving #327
No idea if it actually performs better.
Important
Renames the 'python' tool to 'ipython' for better tool use format adherence, updating initialization and tests accordingly.
python
toipython
ingptme/tools/__init__.py
andgptme/tools/python.py
.init_tools()
to sort byipython
.test_tools_info()
intest_util_cli.py
to check foripython
instead ofpython
.This description was created by for 113fa58. It will automatically update as commits are pushed.