feat: improve tool use response format #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a7b9ef4 in 53 seconds
More details
- Looked at
289lines of code in6files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. gptme/message.py:44
- Draft comment:
Update the docstring to include 'tool_result' as a possible role for the message sender. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a new role 'tool_result' in the Message class, which is used in various places. This change should be reflected in the documentation of the Message class to ensure clarity.
Workflow ID: wflow_Bqw5JXPSO6DeDHb2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
jrmi
force-pushed
the
302-improve-tool-support
branch
7 times, most recently
from
a1cadba to
e63fbab
Compare
jrmi
force-pushed
the
302-improve-tool-support
branch
7 times, most recently
from
8a22723 to
97e7e7c
Compare
jrmi
commented
Dec 13, 2024
jrmi
commented
Dec 13, 2024
| assert len(content) == 1 | ||
| return content[0].text # type: ignore | ||
|
|
||
| parsed_block = [] |
There was a problem hiding this comment.
Tool call was broken with non stream API.
jrmi
commented
Dec 13, 2024
| @@ -99,7 +108,7 @@ def stream( | |||
| block = chunk.content_block | |||
| if isinstance(block, anthropic.types.ToolUseBlock): | |||
| tool_use = block | |||
| yield f"\n@{tool_use.name}: " | |||
| yield f"\n@{tool_use.name}({tool_use.id}): " | |||
There was a problem hiding this comment.
We add the tool uid here to save it in the message.
jrmi
commented
Dec 13, 2024
| @@ -224,7 +303,7 @@ def _transform_system_messages( | |||
|
|
|||
| # for any subsequent system messages, transform them into a <system> message | |||
| for i, message in enumerate(messages): | |||
| if message.role == "system": | |||
| if message.role == "system" and message.call_id is None: | |||
There was a problem hiding this comment.
We don't want to change messages with call_id. They will be handled by the _handle_tool function.
There was a problem hiding this comment.
Add this as a code comment, as it's good to know when reading
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 97e7e7c in 1 minute and 32 seconds
More details
- Looked at
1066lines of code in10files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tests/test_tool_use.py:70
- Draft comment:
The regex pattern for tool calls has been updated to include a call ID, but the test cases here still use the old pattern without the call ID. Update the test cases to include a call ID in the tool call format. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_FEtlgo6qaP9zjkPI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Hey @ErikBjare this MR is ready to review:
Let me know what you think. FYI I tested it with openai and anthropic ;-) |
jrmi
force-pushed
the
302-improve-tool-support
branch
from
97e7e7c to
6e66c1b
Compare
jrmi
force-pushed
the
302-improve-tool-support
branch
3 times, most recently
from
43785e5 to
372163b
Compare
ErikBjare
approved these changes
Dec 16, 2024
2 tasks
jrmi
force-pushed
the
302-improve-tool-support
branch
2 times, most recently
from
7bd93ea to
4b12180
Compare
jrmi
force-pushed
the
302-improve-tool-support
branch
from
4b12180 to
a0c39f2
Compare
ErikBjare
approved these changes
Dec 21, 2024
ErikBjare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to match the expected output for each API regarding tool use response.
It modify the message dicts to match the expected output.
Also fix tool call not working with stream == False