Skip to content

Commit

Permalink
Fix spurious error message in build/checkversion.py
Browse files Browse the repository at this point in the history
There is a meaningless and unhelpful error message appearing at publish
time with some npm versions.  Suppress it by including stderr into the
captured stdout.

Change-Id: I73693433e5df5cc8d63375c08f765fbbb801f10f
  • Loading branch information
joeyparrish committed Oct 26, 2016
1 parent 5edc83c commit 6f47acf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/shakaBuildHelpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def npm_version(is_dirty=False):
cmd = 'npm.cmd' if is_windows() else 'npm'
cmd_line = [cmd, '--prefix', base, 'ls', 'shaka-player']
print_cmd_line(cmd_line)
text = subprocess.check_output(cmd_line)
text = subprocess.check_output(cmd_line, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as e:
text = e.output
match = re.search(r'shaka-player@(.*) ', text)
Expand Down

0 comments on commit 6f47acf

Please sign in to comment.