Enable transport agent and renderer to optionally support OpenGL#553
Closed
alessandrod wants to merge 3 commits intoEricssonResearch:masterfrom
Closed
Enable transport agent and renderer to optionally support OpenGL#553alessandrod wants to merge 3 commits intoEricssonResearch:masterfrom
alessandrod wants to merge 3 commits intoEricssonResearch:masterfrom
Conversation
Use glvideoflip and glcolorbalance. This change assumes that the sink returned by ::get_sink can deal with video/x-raw(memory:GLMemory) like glimagesink, which is what the default implementation uses. Alternatively non-GL sinks can still be used by returning a bin that includes the gldownload element from ::get_sink.
Add gldownload before the encoder to allow both OpenGL and non-OpenGL sources
This allows the transport agent to potentially negotiate and work with OpenGL memory.
Contributor
Author
|
Something I forgot to mention is that for this to work you need gst master as of today (Feb 1st). |
Contributor
|
Bumped to gst* master in cerbero and merged. All looks straightforward. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following patches enable the transport agent and renderer to optionally work with GLMemory. This is part of my work to make OWR offload most video processing to OpenGL in order to improve performance.
This PR doesn't yet include the changes to enable OpenGL at the source, since doing that currently works with H264 but breaks VP8 encoding. I'm submitting this now since these commits are independent from the source changes and don't break anything, so people can start reviewing them.