Modernizing code taking advantage of java17

[tommystendahl]

• switch statements
• instanceof
• text blocks
• streaming toList
• nullpointers
• record

[tommystendahl]

Github Copilot's evaluation of this PR:

I'll look at the details of PR #1036 more closely to evaluate the changes.Let me evaluate the changes in PR #1036:

Scale and Impact:

• The PR touches 52 files with 293 additions and 745 deletions
• This indicates a significant refactoring effort across the codebase
• The net reduction in lines of code (more deletions than additions) suggests the changes are making the code more concise

Quality Aspects:

1. Modernization:

   • The changes leverage Java 17 features which is a positive move for maintainability
   • Using modern language features like switch expressions, pattern matching, and records makes the code more expressive and less error-prone

2. Code Quality:

   • The changes appear to be comprehensive, touching multiple aspects of Java 17 improvements
   • Using features like text blocks improves readability
   • The streaming toList() method simplifies collection handling
   • Better null pointer handling reduces the risk of runtime errors

3. Process:

   • The PR has requested reviews from both an individual reviewer (jwaeab) and the C2T codeowner team
   • It's currently in a "blocked" mergeable state, suggesting it needs to pass some checks or get required approvals
   • The changes are spread across 16 commits, indicating a structured approach to the changes

Areas of Consideration:

1. Testing: With such widespread changes, thorough testing would be crucial
2. Migration Impact: The move to Java 17 features might require updating development environments and build processes
3. Review Coverage: Given the scale of changes, getting thorough code review would be important

Overall Assessment:
These changes appear to be well-thought-out and beneficial for the project:

• They modernize the codebase
• Improve code readability and maintainability
• Reduce potential runtime errors
• Make the code more concise (evident from the net reduction in lines)

The changes align with good software engineering practices by taking advantage of modern language features while presumably maintaining functionality. The careful approach (multiple commits, requested reviews) suggests a methodical modernization effort.

Status: The PR is still open and needs reviews/approvals before it can be merged, but the changes themselves appear to be of good quality and beneficial for the project's long-term health.