Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused Config table from the database #927

Merged
merged 1 commit into from
Sep 14, 2017
Merged

remove unused Config table from the database #927

merged 1 commit into from
Sep 14, 2017

Conversation

gyorb
Copy link
Contributor

@gyorb gyorb commented Sep 14, 2017

No description provided.

@whisperity whisperity added the database 🗄️ Issues related to the database schema. label Sep 14, 2017
@whisperity
Copy link
Contributor

whisperity commented Sep 14, 2017 •
edited
Loading

Shouldn't we also remove the getCheckerConfig() calls from the API and the implementation too? There are handlers for this table.

@whisperity
Copy link
Contributor

Talking about these things:

codechecker/api/v6/report_server.thrift

Lines 265 to 268 in 162dde6

// get the checker configuration values
// PERMISSION: PRODUCT_ACCESS or PRODUCT_STORE
shared.CheckerConfigList getCheckerConfigs(1: i64 runId)
throws (1: shared.RequestFailed requestError),

codechecker/api/v6/report_server.thrift

Lines 377 to 381 in 162dde6

// PERMISSION: PRODUCT_STORE
bool replaceConfigInfo(
1: i64 runId,
2: shared.CheckerConfigList values)
throws (1: shared.RequestFailed requestError),

@gyorb gyorb force-pushed the remove_config_from_db branch 2 times, most recently from c18f7cc to a59abf5 Compare September 14, 2017 11:44
Xazax-hun
Xazax-hun approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whisperity whisperity added the WARN ⚠️: Backward compatibility breaker! MIND THE GAP! Merging this patch will mess up compatibility with the previous releases! label Sep 14, 2017
@whisperity whisperity merged commit 281f272 into Ericsson:master Sep 14, 2017
@gyorb gyorb deleted the remove_config_from_db branch October 16, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whisperity whisperity whisperity approved these changes

@Xazax-hun Xazax-hun Xazax-hun approved these changes

@dkrupp dkrupp Awaiting requested review from dkrupp

Assignees
No one assigned
Labels
database 🗄️ Issues related to the database schema. WARN ⚠️: Backward compatibility breaker! MIND THE GAP! Merging this patch will mess up compatibility with the previous releases!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyorb @whisperity @Xazax-hun