Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new client count/filter api everywhere #918

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Use the new client count/filter api everywhere #918

merged 1 commit into from
Sep 14, 2017

Conversation

gyorb
Copy link
Contributor

@gyorb gyorb commented Sep 14, 2017

  • use the new filtering api in the command line
  • remove the old api calls
  • remove the temporary v2 naming

Last part of #687

@dkrupp dkrupp mentioned this pull request Sep 14, 2017
Closed
6 tasks
@whisperity whisperity added enhancement 🌟 API change 📄 Content of patch changes API! CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands labels Sep 14, 2017
@whisperity whisperity added this to the 6.0 pre4 milestone Sep 14, 2017
whisperity
whisperity requested changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User interface changed, please update docs/user_guide.md too. (--filter is in some "common arguments" section)

libcodechecker/libhandlers/cmd.py Outdated
@@ -131,7 +131,10 @@ def __add_filtering_arguments(parser):
default="::",
help="Filter results. The filter string has the "
"following format: "
"<severity>:<checker_name>:<file_path>")
"[<severities>]:[<checker_names>]:[<file_paths>] "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Variables" in the help should be UPPERCASE.

libcodechecker/libhandlers/cmd.py Outdated
@@ -131,7 +131,10 @@ def __add_filtering_arguments(parser):
default="::",
help="Filter results. The filter string has the "
"following format: "
"<severity>:<checker_name>:<file_path>")
"[<severities>]:[<checker_names>]:[<file_paths>] "
"where severites, checker_names, "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the same syntax: <SEVERITIES>, etc.

libcodechecker/libhandlers/cmd.py Outdated
"<severity>:<checker_name>:<file_path>")
"[<severities>]:[<checker_names>]:[<file_paths>] "
"where severites, checker_names, "
"file_paths should be a coma separated list. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/coma/comma, and list,, not a .

libcodechecker/libhandlers/cmd.py Outdated
"[<severities>]:[<checker_names>]:[<file_paths>] "
"where severites, checker_names, "
"file_paths should be a coma separated list. "
"Eg.: \"high,medium:unix,core:*.cpp,*.h\"")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.:

Use the new client count/filter api everywhere
b25936f 
* use the new filtering api in the command line
* remove the old api calls
* remove the temporary v2 naming
whisperity
whisperity reviewed Sep 14, 2017
View reviewed changes
docs/user_guide.md
@@ -1105,11 +1105,14 @@ positional arguments:

optional arguments:
-h, --help show this help message and exit
-s, --suppressed Filter results to only show suppressed entries.
(default: False)
-s, --suppressed Show only suppressed results instead of only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is suppression still a thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just updated the documentation based on the current command output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeChecker cmd results has a suppressed option

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it does. But does it need to have one, since the new API? Note that detection status and review status changes were introduced without a proper command-line touch-up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've got your point, this should be rechecked later, as you mentioned.

whisperity
whisperity approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider the --suppress option and its justification of existence later on. For now, this is good.

@whisperity whisperity merged commit 162dde6 into Ericsson:master Sep 14, 2017
@gyorb gyorb deleted the filter_api branch October 16, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whisperity whisperity whisperity approved these changes

@csordasmarton csordasmarton Awaiting requested review from csordasmarton

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
API change 📄 Content of patch changes API! CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands enhancement 🌟
Projects
None yet
Milestone
6.0 pre4
Development

Successfully merging this pull request may close these issues.
2 participants
@gyorb @whisperity