Show reports with the same bughash in the bugviewer #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
enhancement 🌟
API change 📄
csordasmarton
force-pushed
the
same_bughash
branch
3 times, most recently
from
efd8566
to
6e3c3b4
Compare
Xazax-hun
suggested changes
Sep 12, 2017
api/v6/report_server.thrift
Outdated
| @@ -184,7 +190,7 @@ service codeCheckerDBAccess { | |||
|
|
|||
| // get the run Ids and dates from the database to select one run | |||
| // PERMISSION: PRODUCT_ACCESS | |||
| RunDataList getRunData(1: string runNameFilter) | |||
| RunDataList getRunData(1: RunFilter runFilter) | |||
There was a problem hiding this comment.
Please make the above comment a full sentence.
api/v6/report_server.thrift
Outdated
| @@ -25,6 +25,11 @@ struct RunData { | |||
| } | |||
| typedef list<RunData> RunDataList | |||
|
|
|||
| struct RunFilter { | |||
| 1: list<i64> runIds, | |||
There was a problem hiding this comment.
What is the connection between the fields? Are they connected with or or and or something else? Please document this.
| @@ -471,7 +471,7 @@ def __get_run_ids_to_query(self, session, cmp_data=None): | |||
| return run_ids | |||
|
|
|||
| @timeit | |||
| def getRunData(self, run_name_filter): | |||
| def getRunData(self, runFilter): | |||
There was a problem hiding this comment.
for python variables prefer lowecase names like run_filter.
csordasmarton
force-pushed
the
same_bughash
branch
from
6e3c3b4
to
a88a28f
Compare
Xazax-hun
approved these changes
Sep 12, 2017
dkrupp
requested changes
Sep 12, 2017
csordasmarton
force-pushed
the
same_bughash
branch
from
a88a28f
to
23fea51
Compare
dkrupp
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.