Local compare mode takes in-code-suppressions into consideration. #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
added
bugfix 🔨
enhancement 🌟
CLI 💻
whisperity
requested changes
Aug 31, 2017
| @@ -21,6 +21,8 @@ | |||
| from libcodechecker.logger import LoggerFactory | |||
| from libcodechecker.output_formatters import twodim_to_str | |||
| from libcodechecker.report import Report | |||
| from libcodechecker import suppress_handler | |||
There was a problem hiding this comment.
Import order is not proper here. from libcodechecker import X must precede from libcodecher.a import b.
tests/functional/diff/__init__.py
Outdated
| @@ -16,6 +16,7 @@ | |||
| import sys | |||
| import time | |||
| import uuid | |||
| from distutils import dir_util | |||
There was a problem hiding this comment.
Import order is not proper here. Not in this line, and not the line directly below.
tests/functional/diff/__init__.py
Outdated
| @@ -45,6 +55,10 @@ def setup_package(): | |||
| test_project = 'cpp' | |||
|
|
|||
| test_project_path = project.path(test_project) | |||
| test_project_path_altered = os.path.join(TEST_WORKSPACE, "cpp_copy") | |||
| # we create a copy of the test project which we will change | |||
There was a problem hiding this comment.
This is not a full sentence.
| @@ -16,6 +16,7 @@ void f(struct S s); | |||
|
|
|||
| void test1() { | |||
| struct S s; | |||
| //insert_suppress_here | |||
There was a problem hiding this comment.
Can we put a space between // and the keyword?
dkrupp
force-pushed
the
local_compare_in_code_suppress
branch
from
3d12010
to
97c6b39
Compare
whisperity
approved these changes
Aug 31, 2017
Xazax-hun
approved these changes
Sep 4, 2017
gyorb
approved these changes
Sep 4, 2017
dkrupp
force-pushed
the
local_compare_in_code_suppress
branch
from
97c6b39
to
26fbe39
Compare
dkrupp
force-pushed
the
local_compare_in_code_suppress
branch
2 times, most recently
from
12e3eaf
to
2b4a2be
Compare
dkrupp
force-pushed
the
local_compare_in_code_suppress
branch
from
2b4a2be
to
b599589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #851