Use two columns radio buttons instead of checkboxes at diff. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
requested changes
Aug 3, 2017
There was a problem hiding this comment.
Feature looks and works fine for most cases.
The buttons appear a bit too "pale" for me, perhaps we could apply an extra style?
Also, I don't really like how the lines in the run list became much more thick due to the button... this is also a styling issue I take.
And there is a bit of a functional issue: the current mode allows diffing the same project with itself, which is, while technically correct, doesn't seem to useful. Perhaps we should add a case that disables it.
csordasmarton
force-pushed
the
diff_radiobtn
branch
from
91a14b7
to
7eed2a5
Compare
|
whisperity
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537.