Bring code borrowed from http.server in sync with upstream
#4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discookie
force-pushed
the
update-httpserver
branch
from
2b80fce
to
208d43b
Compare
cservakt
reviewed
Nov 6, 2024
|
|
||
| if self.path == '/': | ||
| self.path = "index.html" | ||
|
|
||
| # Check that the given path is a file. | ||
| # The base directory is set to www_root. | ||
| if not os.path.exists(self.translate_path(self.path)): |
There was a problem hiding this comment.
You already deleted this translate_path fuction so I think you would have modified this if state.
There was a problem hiding this comment.
I deleted the re-implementation of the translate_path function, this calls SimpleHTTPRequestHandler.translate_path() - translating the path with the root set to www_root.
There was a problem hiding this comment.
Oh OK, I didn't noticed that.
|
Linter passes as of latest commit. |
cservakt
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove translate_path() to rely on http.server's implementation, and fix handling of leading slashes.