Handle ambigous profile/group parameters #4377
Open
+51
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraz31
force-pushed
the
handle_ambigous_parameters
branch
4 times, most recently
from
23f9a04
to
92cbeaa
Compare
Introduce the -e group: option, to improve handling of ambigous parameters (such as "security" etc.)
noraz31
force-pushed
the
handle_ambigous_parameters
branch
from
92cbeaa
to
22f992d
Compare
vodorok
requested changes
Nov 6, 2024
| self.set_checker_enabled(checker, enabled) | ||
| LOG.error(templ.substitute(entity="profile", | ||
| identifier=identifier)) | ||
| sys.exit(1) |
There was a problem hiding this comment.
Is exit status 1 the proper exit code in case of configuration errors?
There was a problem hiding this comment.
Same applies 10 lines below
| @@ -210,23 +212,40 @@ def initialize_checkers(self, | |||
| profiles = checker_labels.get_description('profile') | |||
| guidelines = checker_labels.occurring_values('guideline') | |||
|
|
|||
| templ = Template("The ${entity} name '${identifier}' conflicts with a " | |||
| "checker(-group) name. Please use -e ${entity}: to " | |||
There was a problem hiding this comment.
We should be very specific about what conflicts with what. So if you can provide an exact error message instead of ...with a checker(-group)... then please be specific.
| @@ -23,7 +23,8 @@ def available(ordered_checkers, available_checkers): | |||
| if checker_name.startswith('profile:') or \ | |||
| checker_name.startswith('guideline:') or \ | |||
| checker_name.startswith('severity:') or \ | |||
| checker_name.startswith('sei-cert:'): | |||
| checker_name.startswith('sei-cert:') or \ | |||
| checker_name.startswith('group:'): | |||
There was a problem hiding this comment.
If you plan to introduce a new checker enable prefix, please add this to the documentation and help of CodeChecker analyze and CodeChecker check.
| @@ -216,10 +225,15 @@ def f(checks, checkers): | |||
|
|
|||
| # Enable "security" profile checkers without "profile:" prefix. | |||
| cfg_handler = ClangSA.construct_config_handler(args) | |||
| cfg_handler.initialize_checkers(checkers, | |||
| [('security', True)]) | |||
There was a problem hiding this comment.
Why are you replacing the security prefix? enabling with sensitive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the -e group: option, to improve
handling of ambigous parameters
(such as "security" etc.)