[cmd] Checker name prefixes are meant along separator characters #4311
Conversation
bruntib
added
CLI 💻
| @@ -264,6 +264,18 @@ def f(checks, checkers): | |||
| self.assertTrue(all_with_status(CheckerState.ENABLED) | |||
| (cfg_handler.checks(), low_severity)) | |||
|
|
|||
| # Enable checkers with a checker group prefix. | |||
There was a problem hiding this comment.
this test is enabling one concrete checker alpha.security.ArrayBound and tests that alpha.security.ArrayBoundv2 should not be enabled. It is not testing "checker group prefix"
Could you please add another test case which enables "alpha.security" group. Then alpha.security.ArrayBound and also alpha.security.ArrayBoundv2 should be enabled.
|
Instead of |
Checkers can be enabled by groups, e.g. unix.cstring enables all checkers starting with this prefix. However, unix.cs is not a checker group so this shouldn't be allowed. In this case an error message is printed and analysis doesn't start.
bruntib
force-pushed
the
checker_name_prefix
branch
from
2de944a
to
8893ecd
Compare
|
@dkrupp, @NagyDonat Thanks for the comments! I fixed the tests accordingly. |
Checkers can be enabled by groups, e.g. unix.cstring enables all checkers starting with this prefix. However, unix.cs is not a checker group so this shouldn't be allowed. In this case an error message is printed and analysis doesn't start.