Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't emit a missing gcc warning if no checkers are enabled" #4238

Closed
wants to merge 1 commit into from

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented May 7, 2024

This reverts commit 7b49263.

@bruntib bruntib added this to the release 6.24.0 milestone May 7, 2024
@bruntib bruntib requested review from Szelethus and cservakt May 7, 2024 08:54
@bruntib bruntib requested a review from vodorok as a code owner May 7, 2024 08:54
Copy link
Collaborator

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to elaborate as to why? I recall a crash being mentioned in person.

@whisperity whisperity added analyzer 📈 Related to the analyze commands (analysis driver) gcc 🐃 GNU GCC Static Analyzer labels May 7, 2024
@whisperity
Copy link
Contributor

Note

An equivalent copy of this revert, although unreviewed, is reachable from v6.24.0-rc1 as f05a9bf.

Szelethus added a commit to Szelethus/codechecker that referenced this pull request May 8, 2024
Original patch (that itroduces the crash):
Ericsson#4179
Revert attempt in Ericsson#4238.

The crash occurs because the original patch tries to create config
handlers even if they are not supported. This is playing with fire
already, but the crash occured when not even the analyzer binary is
found.

In this patch, these analyzers are skipped from checking if they have
any checkers enabled.
@bruntib
Copy link
Contributor Author

bruntib commented May 16, 2024

Fixed by #4241

@bruntib bruntib closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) gcc 🐃 GNU GCC Static Analyzer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants