[analyzer] Fix uniqueing compilation commands #3635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are storing unique compilation actions in a map which uses the overriden
__hash__
and__eq__
methods on theBuildAction
class.For this we used the following logic:
In this case we didn't called the function but we checked whether the
function is in the map. Before
Python 3.9
this solution somehow workedbut in later Python versions it will not unique compilation actions properly.
To solve this problem we will use the following logic:
Under the hood the Python interpreter will call the overriden dunder functions.