Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix the prepare debug scripts #3614

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

steakhal
Copy link
Contributor

@steakhal steakhal commented Mar 2, 2022

There are multiple changes in this commit:

  • Expect 'compilation_database.json' instead of 'compile_cmd.json' in
    failed zips.
  • Uplift the 'compiler_info.json' preparation to the 'new' format.
  • Use the expected compiler for '--ctu-collect'.

Since these were broken for quite a while, and these debug scripts are
not for production use, I'm not willing to create tests for this change.

There are multiple changes in this commit:
- Expect 'compilation_database.json' instead of 'compile_cmd.json' in
  failed zips.
- Uplift the 'compiler_info.json' preparation to the 'new' format.
- Use the expected compiler for '--ctu-collect'.

Since these were broken for quite a while, and these debug scripts are
not for production use, I'm not willing to create tests for this change.
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csordasmarton csordasmarton added this to the release 6.19.0 milestone Mar 7, 2022
@csordasmarton csordasmarton merged commit 0fd8a2e into Ericsson:master Mar 7, 2022
@steakhal steakhal deleted the fix-debug-scripts branch March 7, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants