[analyzer] Proper handling of multi-target build #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
bugfix 🔨
analyzer 📈
csordasmarton
suggested changes
Feb 24, 2022
analyzer/codechecker_analyzer/analyzers/clangsa/ctu_triple_arch.py
Outdated
Show resolved
Hide resolved
| "--target=" + self.buildaction.target.get(compile_lang, | ||
| "")) | ||
| self.buildaction.target != "": | ||
| analyzer_cmd.append("--target=" + self.buildaction.target) |
There was a problem hiding this comment.
Suggested change
| analyzer_cmd.append("--target=" + self.buildaction.target) | |
| analyzer_cmd.append(f"--target={self.buildaction.target}") |
CodeChecker collects implicit compiler info, such as implicit include paths, default target, etc. If a compilation_database.json contains build actions with different target compilations (or different sysroot, etc.) then the implicit infos of the first action will be applied to all build actions. With this patch every build action gets its own implicit info.
bruntib
force-pushed
the
multiple_target
branch
from
c051226
to
ba974e1
Compare
|
Looks fine by me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeChecker collects implicit compiler info, such as implicit include
paths, default target, etc. If a compilation_database.json contains
build actions with different target compilations (or different sysroot,
etc.) then the implicit infos of the first action will be applied to
all build actions.
With this patch every build action gets its own implicit info.