[script] Thrift Python client example #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
force-pushed
the
thrift_client_example
branch
from
64a18ae
to
2e0e98a
Compare
bruntib
requested changes
Jan 21, 2022
scripts/thrift/client.py
Outdated
|
|
||
| try: | ||
| print(f"Login '{USERNAME}'...") | ||
| token = cli_auth.performLogin( |
There was a problem hiding this comment.
I have a server locally which doesn't need any authentication. I think this is a good thing that login example is here so the user of this script can see its usage. But shouldn't we make it optional? For example if USERNAME and PASSWORD variables are None then token should also be None so it works without authentication, or something like this.
There was a problem hiding this comment.
From the server we can ask this information whether it requires authentication or not with the getAuthParameters API function. I changed this script to support this use case too what you have mentioned.
csordasmarton
force-pushed
the
thrift_client_example
branch
from
2e0e98a
to
8088099
Compare
bruntib
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.