Removing cppcoreguidelines-virtual-class-destructor from the profiles #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppcoreguidelines-virtual-class-destructor is unstable, so removing it from the profiles. And adding back bugprone-exception-escape to the profiles as it was removed by mistake.
dkrupp
force-pushed
the
remove_virt_destr_checker
branch
from
8478ce9
to
985e318
Compare
|
@steakhal, have you landed the fix about the crashes, macros, etc. involved in this check? In that case, perhaps it could be re-added to the config? |
|
Oh sure. They landed on this Monday. I'll do something about it tomorrow. |
steakhal
pushed a commit
to steakhal/codechecker
that referenced
this pull request
Nov 30, 2021
This patch partially reverts Ericsson#3494 The llvm/llvm-project@0685e83 fixed the issue about the cppcoreguidelines-virtual-base-class-destructor checker, so we can safely include this in the intended profiles.
csordasmarton
pushed a commit
that referenced
this pull request
Dec 9, 2021
This patch partially reverts #3494 The llvm/llvm-project@0685e83 fixed the issue about the cppcoreguidelines-virtual-base-class-destructor checker, so we can safely include this in the intended profiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cppcoreguidelines-virtual-class-destructor is unstable,
so removing it from the profiles