Not allowing disabling modeling checkers in ClangSA #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
suggested changes
May 20, 2021
dkrupp
force-pushed
the
silencing
branch
5 times, most recently
from
3144cd0
to
79e50ed
Compare
csordasmarton
changed the title
csordasmarton
suggested changes
Feb 24, 2022
csordasmarton
added
analyzer 📈
csordasmarton
suggested changes
Feb 25, 2022
When a Clang Static Analyzer checker is disabled in CodeChecker, clang is invoked with the "analyzer-disable-checker" flag. This allows the user disabling core modeling checkers such as unix.DynamicMemoryModeling. This causes malfunctioning of depending checkers. Breaking Change: After this patch, modeling and debug checkers (listed with clang -cc1 -analyzer-checker-help-developer) will not be listed and cannot be disabled through CodeChecker with the --enable and --disable flags. They can be enabled/disabled through the Clang Static Analyzer specific --saargs flag only.
|
Thanks for the review. All comments fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Clang Static Analyzer checker is disabled in CodeChecker, clang is invoked with the
analyzer-disable-checkerflag. This allows the user disabling core modeling checkers such asunix.DynamicMemoryModeling. This causes malfunctioning of depending checkers.❗ ❗ ❗ Breaking Change: ❗ ❗ ❗
After this patch,
modelinganddebugcheckers (listed withclang -cc1 -analyzer-checker-help-developer)will not be listed and cannot be disabled through CodeChecker with the
--enableand--disableflags.They can be enabled/disabled through the Clang Static Analyzer specific
--saargsflag only.