[web] Support config file #2611
Conversation
csordasmarton
commented
Mar 13, 2020
csordasmarton
commented
csordasmarton
added
enhancement 🌟
test ☑️
labels
| "emplaced as command line arguments. The format " | ||
| "of configuration file is: " | ||
| "{" | ||
| " \"enabled\": true," |
There was a problem hiding this comment.
The .codechecker.passwords.json and the server_config.json look the same: both have an option to turn off or on the feature. I wanted to be more consistent with these features. By the way the analyzer --config option works the same so if we would like to change this behaviour we can do it in another pull request. Maybe we can create an issue for this.
There was a problem hiding this comment.
I've created a separate issue to discuss it #2654
csordasmarton
force-pushed
the
web_config_file
branch
from
b9ea9f2
to
8986ed7
Compare
| @@ -0,0 +1,70 @@ | |||
| # coding=utf-8 | |||
There was a problem hiding this comment.
the coding part is not needed by default in py3 every file should be utf-8
| "emplaced as command line arguments. The format " | ||
| "of configuration file is: " | ||
| "{" | ||
| " \"enabled\": true," |
There was a problem hiding this comment.
I've created a separate issue to discuss it #2654
csordasmarton
force-pushed
the
web_config_file
branch
from
8986ed7
to
cd20886
Compare
|
@gyorgy I already commented on that issue. We can also remove it later if we do not want to keep that. |
csordasmarton
force-pushed
the
web_config_file
branch
2 times, most recently
from
25707a6
to
fafa224
Compare
|
@gyorb Okay, I have removed this |
docs/web/user_guide.md
Outdated
| { | ||
| "store": [ | ||
| "--name=run_name", | ||
| "--tag=my_tag" |
There was a problem hiding this comment.
| "--tag=my_tag" | |
| "--tag=my_tag", |
A comma is missing, the json is invalid without it.
There was a problem hiding this comment.
Good catch, thanks!
csordasmarton
force-pushed
the
web_config_file
branch
from
fafa224
to
e4d7a8a
Compare
|
Complexity increasing per file
==============================
- web/tests/functional/cli_config/__init__.py 1
- web/tests/functional/cli_config/test_store_config.py 3
- web/tests/functional/cli_config/test_server_config.py 3
Clones added
============
- web/client/codechecker_client/cmd/store.py 1
- web/tests/functional/cli_config/test_store_config.py 1
- web/tests/functional/cli_config/test_server_config.py 7
- web/server/codechecker_server/cmd/server.py 1
See the complete overview on Codacy |
