Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codechecker.executor.showOutput command #144

Merged
merged 1 commit into from
May 15, 2024

Conversation

Discookie
Copy link
Collaborator

Requires #140 for CI passing.

In some locations, the commands codechecker.logging.showOutput and codechecker.executor.showOutput were inconsistently used. They are now all codechecker.executor.showOutput.
Fixes sidebar commands when CodeChecker is running, among others.

@Discookie Discookie requested a review from vodorok April 8, 2024 09:36
@Discookie Discookie force-pushed the ericsson/fix-showoutput-command branch 2 times, most recently from a367ad4 to b055dd6 Compare April 10, 2024 08:53
@Discookie Discookie force-pushed the ericsson/fix-showoutput-command branch from b055dd6 to 597a30f Compare April 17, 2024 08:11
Copy link
Collaborator

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vodorok vodorok merged commit 7f9b31c into Ericsson:main May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants