Fix to prevent cssFrameworkStyles from being output further down the DOM in tree #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
vue-web-component-wrapperfrom outputting thecssFrameworkStyles. This makes sure the component styles can override thecssFrameworkStylesStackblitz: https://stackblitz.com/edit/vitejs-vite-qvbmtobb
It looks like this
nameattribute was removed previously but I'm unsure why.During this I also discovered that the
<style>tags are output twice. When using shadowDOM, they are output at the top of the shadowDOM in the wrong order with the cssFrameworkStyles lowest in the DOM tree. They are also output within the first element within the shadowDOM.This doesn't happen with the
shadowDOMdisabled: https://stackblitz.com/edit/vitejs-vite-nxzqsdqz with this fix. Without this fix then thecssFrameworkStylesare output twiceI have a feeling that the issues stem from Vue's
defineCustomElementtrying to handle styles as well asvue-web-component-wrappertrying to handle them