review-web-app: add shadcn token audits (coverage + theme integrity)#12
Merged
Conversation
…rity) A kuat-mono consumer test showed shadcn init/add can silently override Kuat's semantic tokens even when a component looks fine, since coverage review alone only checks token names, not resolved values. Add a token audits step to review-web-app that diffs any shadcn/third-party item against kuat-core's shipped token-contract.json for both missing tokens and overridden values, with a fixed resolution rule (add to kuat-core, never leave a token on a shadcn default) and a feedback record for gaps. Rebuilt plugins/kuat-build via skills/scripts/build-plugin.mjs to propagate the source change into the packaged plugin copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shadcn init/addcan silently override Kuat's semantic tokens (an unlayered shadcn:rootbeats kuat-core's layered tokens regardless of import order) even when the added component renders fine — coverage review alone (token names) misses this because it never checks resolved values.review-web-appfor any shadcn/third-party UI item in scope, run against the shipped@equal-experts/kuat-core/token-contract.json::root/.darkand diff each semantic token's resolved colour against the contract. Reports ✅ intact /.kuat/feedback/.kuat-coreaudit bins is called out as an open packaging decision, not assumed here.plugins/kuat-buildvianode skills/scripts/build-plugin.mjsso the packaged copy ofreview-web-apppicks up the change (diff-checked — only the intended content + routine ref/date stamps landed).Context for reviewers
docs/shadcn/agent-rules-skill-fixes.md). The other half — fixing thekuat-reactskill's first-time-setup so it doesn't clobber Kuat's theme when shadcn is added — lives inkuat-claude-plugin(separate repo, no PR here) and has already been applied there.plugins/kuat-studioshows no skill diff since it doesn't bundlereview-web-app; its manifest/changelog only picked up the routine rebuild ref/date stamp (repo HEAD advanced earlier in this session viagit pull).Test plan
node skills/scripts/build-plugin.mjsand diffed the generatedplugins/kuat-build/skills/review-web-app/SKILL.md— confirmed only the new content (path-rewritten) landed, no driftdocs/migration/evals/review-web-app.md's existing pattern🤖 Generated with Claude Code