fix: fix loading of string resources in code #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: Eppie-io#411
References: Eppie-io#411
al-kau
added
type/fix
ValeraFinebits
approved these changes
Nov 5, 2024
ValeraFinebits
pushed a commit
that referenced
this pull request
Nov 5, 2024
* refactor: create Eppie.App.Resources library (#412) feat: create Eppie.App.Resources library References: #411 * refactor: move resw files to Eppie.App.Resources library (#414) References: #411 * fix: fix loading of string resources in code (#415) * feat: create StringProvider References: #411 * refactor: use StringProvider References: #411 * fix: correct x:Uid keys (#416) References: #411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #411
Description
StringProviderthat loads strings from the Eppie.App.Resources libraryResourceLoaderwithStringProviderOther Information
Pull Request Checklist
Please check if your pull request fulfills the following requirements:
Note
Types of pull requests
feat- adding new featuresfix- bug fixestest- adding or correcting testsperf- changes that improve performancerefactor- simple rewriting or restructuring of code without adding new features or fixing bugsstyle- changes in code styles and no changes in logicbuild- changes related to the build of the project and dependenciesci- changes related to continuous integrationdocs- changes in documentation or just comments in source codechore- something that doesn't fit the other possible typesPull request labels
type/breaking-change- pull requests with changes that are not backward compatibletype/build- pull requests that change the project's build or dependenciestype/chore- pull requests without making changes to the code, project build, formatting, documentation, etctype/ci- pull requests whose changes are related to continuous integrationtype/documentation- pull requests that only change documentationtype/feature- pull requests that add new featurestype/fix- pull requests that fix a bugtype/localization- pull requests that change translationtype/performance- pull requests that improve performancetype/refactor- pull requests that refactor a section of codetype/style- pull requests that change code stylestype/test- pull requests that add or correct testsignore-for-release- for pull requests that do not need to be appeared in release notesA pull request appears in the release notes if it has one of the labels:
type/breaking-change,type/feature,type/fix,type/localization,type/performanceAffected platforms labels
platform/all- pull requests that are related to the all platformsplatform/android- pull requests that are related to the Android platformplatform/desktop- pull requests that are related to the desktopplatform/ios- pull requests that are related to the iOS platformplatform/macos- pull requests that are related to the macOS platformplatform/other- pull requests that are related to an unknown platformplatform/uwp- pull requests that are related to the Universal Windows Platformplatform/wasm- pull requests that are related to the WebAssembly platformplatform/winui- pull requests that are related to the WinUI platform