Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change build workflow #346

Conversation

al-kau
Copy link
Collaborator

@al-kau al-kau commented Sep 24, 2024

Issue

Related to #332

Description

  • fix the build of WinUI and UWP projects
  • change the name of the 'build' job

Other Information

Pull Request Checklist

Please check if your pull request fulfills the following requirements:

Note

Types of pull requests
  • feat - adding new features
  • fix - bug fixes
  • test - adding or correcting tests
  • perf - changes that improve performance
  • refactor - simple rewriting or restructuring of code without adding new features or fixing bugs
  • style - changes in code styles and no changes in logic
  • build - changes related to the build of the project and dependencies
  • ci - changes related to continuous integration
  • docs - changes in documentation or just comments in source code
  • chore - something that doesn't fit the other possible types
Pull request labels
  • type/breaking-change - pull requests with changes that are not backward compatible
  • type/build - pull requests that change the project's build or dependencies
  • type/chore - pull requests without making changes to the code, project build, formatting, documentation, etc
  • type/ci - pull requests whose changes are related to continuous integration
  • type/documentation - pull requests that only change documentation
  • type/feature - pull requests that add new features
  • type/fix - pull requests that fix a bug
  • type/localization - pull requests that change translation
  • type/performance - pull requests that improve performance
  • type/refactor - pull requests that refactor a section of code
  • type/style - pull requests that change code styles
  • type/test - pull requests that add or correct tests
  • ignore-for-release - for pull requests that do not need to be appeared in release notes

A pull request appears in the release notes if it has one of the labels: type/breaking-change, type/feature, type/fix, type/localization, type/performance

Affected platforms labels
  • platform/all - pull requests that are related to the all platforms
  • platform/android - pull requests that are related to the Android platform
  • platform/desktop - pull requests that are related to the desktop
  • platform/ios - pull requests that are related to the iOS platform
  • platform/macos - pull requests that are related to the macOS platform
  • platform/other - pull requests that are related to an unknown platform
  • platform/uwp - pull requests that are related to the Universal Windows Platform
  • platform/wasm - pull requests that are related to the WebAssembly platform
  • platform/winui - pull requests that are related to the WinUI platform

@al-kau al-kau added platform/uwp Categorizes an issue or PR as relevant to the Universal Windows Platform platform/winui Categorizes an issue or PR as relevant to the WinUI platform type/ci Pull requests with changes related to Сontinuous Integration labels Sep 24, 2024
@al-kau al-kau marked this pull request as ready for review September 24, 2024 08:21
@ValeraFinebits ValeraFinebits merged commit 5459add into Eppie-io:feature/296-upgrading-to-uno-platform-5 Sep 24, 2024
3 checks passed
@al-kau al-kau deleted the fix/332-continuous-integration-building branch September 24, 2024 09:14
al-kau added a commit that referenced this pull request Oct 1, 2024
* ci: fix build workflow

Correct the msbuild cli option.

References: #332

* ci: fix build config

References: #332

* ci: change the name of the 'build' job

References: #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/uwp Categorizes an issue or PR as relevant to the Universal Windows Platform platform/winui Categorizes an issue or PR as relevant to the WinUI platform type/ci Pull requests with changes related to Сontinuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants