Remove the CanUsersChat check from selected commands#2071
Open
YellowCreativity wants to merge 3 commits intoEpix-Incorporated:masterfrom
Open
Remove the CanUsersChat check from selected commands#2071YellowCreativity wants to merge 3 commits intoEpix-Incorporated:masterfrom
YellowCreativity wants to merge 3 commits intoEpix-Incorporated:masterfrom
Conversation
Author
|
I can't seem to request a review for whatever reason, so I'll just mention the people I'd like it from primarily: |
YellowCreativity
changed the title
Author
|
I am agreeing with ccuser for once #2033 (comment) |
Member
|
Alert and Notification yeah, kinda iffy about messagepm and notifypm and TTS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected:
AlertMessagePMChatNotifyTextToSpeechNotifyPMNotificationMy reasoning is basically consistent across all of the commands mentioned above, they do not offer 2 way communication, and imo fall under "Any user-generated text unrelated to a conversation" and/or "Moderation audit logs or messages" (at least how I interpret the messages part) within the Text Chat Usage Guidelines.