fix(workspace,filesystem,sync): annotate implicit any parameters across production files#1694
Open
fix(workspace,filesystem,sync): annotate implicit any parameters across production files#1694
Conversation
…ss production files Adds type annotations to all parameters with implicit any types in production files across three packages. Zero behavior changes—purely mechanical annotations to eliminate TS7006 errors. workspace: 23 params across 9 files (Yjs callbacks, catch clauses, schema validators, timeline iterators) filesystem: 13 params across 4 files (POSIX methods, Y.Map forEach, table observers, SQLite rows) sync: 9 encoder params in protocol.ts (lib0 encoding callbacks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The three packages had 45 implicit
anyparameters scattered across production files. These accumulated because the tsconfigs don't always resolve external module types (Yjs, lib0, etc.), so callback parameter types can't be inferred. This PR annotates all of them in one pass—zero TS7006 errors remain in production files.What changed
14 files, net +49 lines. All changes are type annotations only—zero behavior changes.
workspace (23 params, 9 files)
Y.YArrayEvent,Y.Transaction,Y.Item)y-keyvalue.ts,y-keyvalue-lww.tssheet.ts,timeline.tstimeline.tsschema-union.ts,standard-schema.tsunknownwebsocket.ts,datetime-string.ts,y-keyvalue-lww.ts,y-keyvalue.tsprepare-markdown-files.tsfilesystem (13 params, 4 files)
path: stringparamsfile-system.tsformats/markdown.tschangedIds: ReadonlySet<string>tree/path-index.tsextensions/sqlite-index/index.tssync (9 params, 1 file)
encoder: encoding.Encodercallbacksprotocol.tsFollows the same pattern as PR #1690 which fixed 8 type errors in workspace production files.