Skip to content

fix(workspace,filesystem,sync): annotate implicit any parameters across production files#1694

Open
braden-w wants to merge 1 commit intomainfrom
fix/annotate-implicit-any-params
Open

fix(workspace,filesystem,sync): annotate implicit any parameters across production files#1694
braden-w wants to merge 1 commit intomainfrom
fix/annotate-implicit-any-params

Conversation

@braden-w
Copy link
Copy Markdown
Member

Why

The three packages had 45 implicit any parameters scattered across production files. These accumulated because the tsconfigs don't always resolve external module types (Yjs, lib0, etc.), so callback parameter types can't be inferred. This PR annotates all of them in one pass—zero TS7006 errors remain in production files.

What changed

14 files, net +49 lines. All changes are type annotations only—zero behavior changes.

workspace (23 params, 9 files)

Fix Files
Yjs observe callbacks (Y.YArrayEvent, Y.Transaction, Y.Item) y-keyvalue.ts, y-keyvalue-lww.ts
Y.Map forEach iterators sheet.ts, timeline.ts
Y.XmlFragment children timeline.ts
Schema validator params schema-union.ts, standard-schema.ts
Catch-clause-style params → unknown websocket.ts, datetime-string.ts, y-keyvalue-lww.ts, y-keyvalue.ts
Markdown file filter callback prepare-markdown-files.ts

filesystem (13 params, 4 files)

Fix Files
POSIX method path: string params file-system.ts
Y.Map forEach iterators formats/markdown.ts
Table observer changedIds: ReadonlySet<string> tree/path-index.ts
SQLite row shape + change set types extensions/sqlite-index/index.ts

sync (9 params, 1 file)

Fix Files
lib0 encoder: encoding.Encoder callbacks protocol.ts

Follows the same pattern as PR #1690 which fixed 8 type errors in workspace production files.

…ss production files

Adds type annotations to all parameters with implicit any types in
production files across three packages. Zero behavior changes—purely
mechanical annotations to eliminate TS7006 errors.

workspace: 23 params across 9 files (Yjs callbacks, catch clauses,
schema validators, timeline iterators)
filesystem: 13 params across 4 files (POSIX methods, Y.Map forEach,
table observers, SQLite rows)
sync: 9 encoder params in protocol.ts (lib0 encoding callbacks)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant