feat(whispering): add overlay for visual feedback using SvelteKit-routes#1297
Open
vishesh-sachan wants to merge 35 commits intoEpicenterHQ:mainfrom
Open
feat(whispering): add overlay for visual feedback using SvelteKit-routes#1297vishesh-sachan wants to merge 35 commits intoEpicenterHQ:mainfrom
vishesh-sachan wants to merge 35 commits intoEpicenterHQ:mainfrom
Conversation
…transition, and update theme colors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Overlay to SvelteKit Route Architecture
Overview
This PR builds on top of the previous overlay service implementation ( #1159 ) and migrates the overlay from a separate Vite build to a SvelteKit route-based architecture. This simplification was suggested by @Leftium, following patterns used in projects like iRaceHUD.
What Changed
Build System Simplification
vite.overlay.config.ts- separate overlay build configurationbuild:overlayandcopy:overlayscripts from package.jsonvite buildcommand instead of coordinated dual buildsFile Structure Reorganization
Before:
After:
Rust WebviewUrl Update
Before:
After:
Additional Improvements (Leftium's Suggestions)
1. Simplified Error Handling
2. Reduced Excessive Logging
info!()calls in overlay.rsWhat Stayed the Same
Service Layer (100% Unchanged)
src/lib/services/overlay/overlay-service.ts- Core service logicsrc/lib/services/overlay/types.ts- Type definitionsshowRecording(),showTranscribing(),hide(), etc.Rust Window Management
src-tauri/src/overlay.rs- Native window creation and managementoverlay-state,overlay-data-update)Overlay Functionality
Benefits
Developer Experience
Build System
Bundle Optimization
Testing Done
Migration Stats
Credits
Breaking Changes
None. The overlay service API is unchanged, and all existing functionality is preserved.
Follow-up Tasks