Updated file transfer receive code. #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For ref. #370 |
Belchy06
requested changes
Dec 18, 2024
| file.receiving = false; | ||
| file.valid = true; | ||
| Logger.Info('Received complete file'); | ||
| const transferDuration = new Date().getTime() - file.timestampStart; | ||
| const transferBitrate = Math.round((file.size * 16 * 1024) / transferDuration); | ||
| const transferBitrate = Math.round((file.chunks * maxPayloadSize) / transferDuration); |
There was a problem hiding this comment.
Think maxPayloadSize should be maxMessageSize. The transfer bitrate calculation should still include the 5 byte header because even though it wasn't used in the file contents, it was still transferred data.
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mcottontensor
added a commit
that referenced
this pull request
Dec 18, 2024
[UE5.3] Merge pull request #371 from mcottontensor/file-transfer-clarity
mcottontensor
added a commit
that referenced
this pull request
Dec 18, 2024
[UE5.4] Merge pull request #371 from mcottontensor/file-transfer-clarity
mcottontensor
added a commit
that referenced
this pull request
Dec 18, 2024
[UE5.5] Merge pull request #371 from mcottontensor/file-transfer-clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The code for reading file content over the data channel was confusing and hard to decipher leading to accusations of it being incorrect.
Solution
Renamed some variables and added some more descriptive constants to allow easier readability.