Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Auto connect on new streamer #358

Merged
merged 13 commits into from
Sep 11, 2023
Merged

Auto connect on new streamer #358

merged 13 commits into from
Sep 11, 2023

Conversation

mcottontensor
Copy link
Contributor

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

If the front end tries to join a stream before the streamer is connected it requires a click to connect once the streamer has connected.

Solution

This adds a new signalling message to the signalling server that broadcasts to all players that a new streamer has connected to the signalling server. The front end will respond to this if it's waiting, by auto joining the new stream.

Test Plan and Compatibility

None

lukehb
lukehb previously approved these changes Sep 8, 2023
@@ -6,6 +6,7 @@ import {
MessageRecvTypes,
MessageConfig,
MessageStreamerList,
MessageStreamerConnected,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I would really prefer us to not add a new protocol message until we have a mechanism to transmit the signaling protocol and version.

If we absolutely can't achieve this another way then I guess by our own rules:

https://github.com/EpicGames/PixelStreamingInfrastructure/blob/master/SignallingWebServer/Docs/SignallingProtocol.md

This qualifies as a minor version bump in the signalling protocol (as it is independent and not a required message).

Could we also just sit in a timer and try again every few seconds if we couldn't connect and got back no streamers connected. I know it is more wasteful - but also no signaling change.

What do you think @mcottontensor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I can update it to just be a timer.

@mcottontensor mcottontensor dismissed lukehb’s stale review September 11, 2023 00:33

Rewrote the implementation.

Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change to expose interval as a setting.

Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion to change most recent setting name.

@mcottontensor mcottontensor merged commit aeddc8f into EpicGames:master Sep 11, 2023
1 check passed
@mcottontensor mcottontensor deleted the early_reconnect branch September 11, 2023 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants