-
Notifications
You must be signed in to change notification settings - Fork 260
Auto connect on new streamer #358
Auto connect on new streamer #358
Conversation
… the signalling server
@@ -6,6 +6,7 @@ import { | |||
MessageRecvTypes, | |||
MessageConfig, | |||
MessageStreamerList, | |||
MessageStreamerConnected, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I would really prefer us to not add a new protocol message until we have a mechanism to transmit the signaling protocol and version.
If we absolutely can't achieve this another way then I guess by our own rules:
This qualifies as a minor version bump in the signalling protocol (as it is independent and not a required message).
Could we also just sit in a timer and try again every few seconds if we couldn't connect and got back no streamers connected. I know it is more wasteful - but also no signaling change.
What do you think @mcottontensor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I can update it to just be a timer.
…er joins the signalling server" This reverts commit bcc6bc7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change to expose interval as a setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion to change most recent setting name.
Relevant components:
Problem statement:
If the front end tries to join a stream before the streamer is connected it requires a click to connect once the streamer has connected.
Solution
This adds a new signalling message to the signalling server that broadcasts to all players that a new streamer has connected to the signalling server. The front end will respond to this if it's waiting, by auto joining the new stream.
Test Plan and Compatibility
None