Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stores): add fi, gb, ee, lv stores and remove closed gb store #152

Merged
merged 8 commits into from
Jan 3, 2023

Conversation

Teko012
Copy link
Contributor

@Teko012 Teko012 commented Jan 2, 2023

Pull Request

Problem

Some fi, ee, lv and gb stores were missing

Solution

Add new stores, remove closed store

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

📊 Package size report   No changes

File Before After
Total (Includes all files) 121.5 kB 121.5 kB
Tarball size 29.6 kB 29.6 kB
Unchanged files
File Size
LICENSE 1.1 kB
package.json 2.5 kB
README.md 24.3 kB
source/cli-stock.js 4.9 kB
source/cli-stores.js 2.3 kB
source/cli.js 414 B
source/data/buCodes.csv 3.0 kB
source/data/stores.json 53.8 kB
source/index.js 1.2 kB
source/lib/iows2.js 8.8 kB
source/lib/iows2Errors.js 653 B
source/lib/reporter/stock-json.js 120 B
source/lib/reporter/stock-table.js 2.7 kB
source/lib/reporter/stock-tsv.js 478 B
source/lib/reporter/stores-table.js 941 B
source/lib/stores.js 3.7 kB
types/cli-stock.d.ts 70 B
types/cli-stock.d.ts.map 115 B
types/cli-stores.d.ts 71 B
types/cli-stores.d.ts.map 117 B
types/cli.d.ts 64 B
types/cli.d.ts.map 103 B
types/index.d.ts 348 B
types/index.d.ts.map 122 B
types/lib/iows2.d.ts 4.2 kB
types/lib/iows2.d.ts.map 844 B
types/lib/iows2.test.d.ts 51 B
types/lib/iows2.test.d.ts.map 124 B
types/lib/iows2Errors.d.ts 525 B
types/lib/iows2Errors.d.ts.map 268 B
types/lib/reporter/stock-json.d.ts 89 B
types/lib/reporter/stock-json.d.ts.map 147 B
types/lib/reporter/stock-json.test.d.ts 56 B
types/lib/reporter/stock-json.test.d.ts.map 146 B
types/lib/reporter/stock-table.d.ts 586 B
types/lib/reporter/stock-table.d.ts.map 238 B
types/lib/reporter/stock-table.test.d.ts 57 B
types/lib/reporter/stock-table.test.d.ts.map 148 B
types/lib/reporter/stock-tsv.d.ts 85 B
types/lib/reporter/stock-tsv.d.ts.map 145 B
types/lib/reporter/stores-table.d.ts 85 B
types/lib/reporter/stores-table.d.ts.map 151 B
types/lib/stores.d.ts 1.2 kB
types/lib/stores.d.ts.map 292 B
types/lib/stores.test.d.ts 52 B
types/lib/stores.test.d.ts.map 126 B

🤖 This report was automatically generated by pkg-size-action

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Code Coverage Report

Coverage after merging fix/add-stores into master

99.17%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
source
   index.js100%100%100%
source/lib
   iows2.js87.88%100%100%134, 134, 144, 232
   iows2Errors.js100%100%100%
   stores.js92.86%100%100%46
source/lib/reporter
   stock-json.js100%100%100%
   stock-table.js92.86%100%96.67%83, 84

@Teko012
Copy link
Contributor Author

Teko012 commented Jan 2, 2023

@Ephigenia I'm sure there are some other stores missing. Maybe it could be auto generated from these: https://www.ikea.com/fi/fi/meta-data/navigation/stores-detailed.json

@Teko012 Teko012 changed the title fix(stores): add fi, gb store, remove closed gb store fix(stores): add fi, gb, ee, lv store, remove closed gb store Jan 2, 2023
@Teko012 Teko012 changed the title fix(stores): add fi, gb, ee, lv store, remove closed gb store fix(stores): add fi, gb, ee, lv stores and remove closed gb store Jan 2, 2023
Copy link
Owner

@Ephigenia Ephigenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested all the added stores and countries! Thanks for the contribution and extending the list of supported countries!

@Ephigenia
Copy link
Owner

@Ephigenia I'm sure there are some other stores missing. Maybe it could be auto generated from these: https://www.ikea.com/fi/fi/meta-data/navigation/stores-detailed.json

Nice find! This even works for other countries and languages! Awesome I’ll add it!

@Ephigenia
Copy link
Owner

Added a project entry for this to not forget it if you might want to follow: #156

@Ephigenia Ephigenia merged commit 694e514 into Ephigenia:master Jan 3, 2023
@Teko012 Teko012 deleted the fix/add-stores branch January 3, 2023 09:09
@Teko012
Copy link
Contributor Author

Teko012 commented Jan 3, 2023

@Ephigenia Great! You could parse the available options from the localizedSites from here: https://www.ikea.com/global/en/shared-data/regions.js Most of it supports this, the rest (the list is fairly small) could be some kind of manual check/maybe a CI check where it calls the API and reports back if it finds a store or country not in the list maybe. That way we could extend it further easily if the API supports it (right now it just dies with a nodeJS error).

github-actions bot pushed a commit that referenced this pull request Jan 3, 2023
## [1.2.1](v1.2.0...v1.2.1) (2023-01-03)

### Bug Fixes

* **stores:** add fi, gb, ee, lv stores and remove closed gb store ([#152](#152)) ([694e514](694e514))
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

🎉 This PR is included in version 2.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants