fix: apply init values after reduce

[avik-pal]

the breakage in GB was likely from #892. Testing in PRONTOLab/GB-25#50

[giordano]

he breakage in GB was likely from #892.

Wrong link? #892 is an open PR.

[avik-pal]

Oops yeah #882 is the source of breakage

[avik-pal]

GB-25 tests pass

[giordano]

I believe this PR broke the CI job Julia 1.10 - core - ubuntu-24.04 - PJRT - assertions=true:

julia: /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:768: var_lt: Assertion `bb->ub != (jl_value_t*)b' failed.

[14882] signal (6.-6): Aborted
in expression starting at /home/runner/work/Reactant.jl/Reactant.jl/test/wrapped_arrays.jl:69
pthread_kill at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
gsignal at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7faa11c2881a)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
var_lt at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:768
local_forall_exists_subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1594
subtype_ccheck at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:685
var_gt at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:795
local_forall_exists_subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1572
forall_exists_equal at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1698
subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1492
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:948
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:948
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:948
local_forall_exists_subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1594
subtype_ccheck at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:685
equal_var at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1643 [inlined]
forall_exists_equal at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1693
subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1492
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:948
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:955
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:955
subtype_tuple_tail at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1261 [inlined]
subtype_tuple at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1340 [inlined]
subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1486
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:948
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:948
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:955
subtype_unionall at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:955
exists_subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1716 [inlined]
forall_exists_subtype at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:1745
ijl_subtype_env at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:2204
jl_type_intersection_env_s at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/subtype.c:4315
jl_typemap_intersection_node_visitor at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/typemap.c:543
jl_typemap_intersection_visitor at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/typemap.c:770
jl_typemap_intersection_visitor at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/typemap.c:770
ml_mtable_visitor at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/gf.c:3296 [inlined]
ml_matches at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/gf.c:3669
ml_matches at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/gf.c:3588 [inlined]
ijl_matching_methods at /home/runner/work/Reactant.jl/Reactant.jl/julia/src/gf.c:2284
_methods_by_ftype at ./reflection.jl:1031
_findall at ./compiler/methodtable.jl:105 [inlined]
#findall#281 at ./compiler/methodtable.jl:74 [inlined]
findall at ./compiler/methodtable.jl:73 [inlined]
#findall#283 at ./compiler/methodtable.jl:119
[...]

[avik-pal]

findall doesn't use mapreduce, no?

[giordano]

I don't know, but the merge commit on main is the first one where this error appeared, which is now systematic (CI is always red...) and it failed also here

[avik-pal]

Lets revert and check once

[giordano]

For the record, it turned out that this PR also broke precompilation of the GB-25 environment (when the precompilation workload is run) on hydra (independently confirmed also by @jumerckx): PRONTOLab/GB-25#40 (comment). This is now fixed on main, and git bisect identified #915 as the solution. So yeah, there was definitely something broken here.