Skip to content

fix: update distributed APIs to new jll #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix: update distributed APIs to new jll #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Reactant"
uuid = "3c362404-f566-11ee-1572-e11a4b42c853"
authors = ["William Moses <wmoses@mit.edu>", "Valentin Churavy <vchuravy@mit.edu>", "Sergio Sánchez Ramírez <sergio.sanchez.ramirez@bsc.es>", "Paul Berg <paul@plutojl.org>", "Avik Pal <avikpal@mit.edu>", "Mosè Giordano <mose@gnu.org>"]
version = "0.2.144"
version = "0.2.145"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down Expand Up @@ -90,7 +90,7 @@ PythonCall = "0.9.25"
Random = "1.10"
Random123 = "1.7"
ReactantCore = "0.1.15"
Reactant_jll = "0.0.216"
Reactant_jll = "0.0.217"
ScopedValues = "1.3.0"
Scratch = "1.2"
Sockets = "1.10"
Expand Down
7 changes: 0 additions & 7 deletions src/xla/Distributed.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ function DistributedRuntimeClient(
rpc_timeout_in_seconds::Integer=120,
shutdown_timeout_in_minutes::Integer=5,
heartbeat_interval_in_seconds::Integer=10,
max_missing_heartbeats::Integer=10,
use_compression::Bool=true,
)
GC.@preserve coordinator_bind_address begin
Expand All @@ -24,7 +23,6 @@ function DistributedRuntimeClient(
Int32(rpc_timeout_in_seconds)::Int32,
Int32(shutdown_timeout_in_minutes)::Int32,
Int32(heartbeat_interval_in_seconds)::Int32,
Cint(max_missing_heartbeats)::Cint,
use_compression::Bool,
)::Ptr{Cvoid}
end
Expand Down Expand Up @@ -69,7 +67,6 @@ function DistributedRuntimeService(
coordinator_bind_address::String,
num_nodes::Integer;
heartbeat_interval_in_seconds::Integer=10,
max_missing_heartbeats::Integer=10,
cluster_register_timeout_in_minutes::Integer=60,
shutdown_timeout_in_minutes::Integer=5,
)
Expand All @@ -78,7 +75,6 @@ function DistributedRuntimeService(
coordinator_bind_address::Cstring,
Cint(num_nodes)::Cint,
Int32(heartbeat_interval_in_seconds)::Int32,
Cint(max_missing_heartbeats)::Cint,
Int32(cluster_register_timeout_in_minutes)::Int32,
Int32(shutdown_timeout_in_minutes)::Int32,
)::Ptr{Cvoid}
Expand Down Expand Up @@ -135,7 +131,6 @@ function update!(
rpc_timeout_in_seconds::Integer=120,
shutdown_timeout_in_minutes::Integer=5,
heartbeat_interval_in_seconds::Integer=10,
max_missing_heartbeats::Integer=10,
use_compression::Bool=true,
)
@assert 0 ≤ process_id < num_processes
Expand Down Expand Up @@ -166,7 +161,6 @@ function update!(
coordinator_bind_address,
num_processes;
heartbeat_interval_in_seconds,
max_missing_heartbeats,
cluster_register_timeout_in_minutes,
shutdown_timeout_in_minutes,
)
Expand All @@ -189,7 +183,6 @@ function update!(
rpc_timeout_in_seconds,
shutdown_timeout_in_minutes,
heartbeat_interval_in_seconds,
max_missing_heartbeats,
use_compression,
)
@debug "[PID $(process_id)] Connecting to Reactant distributed service on \
Expand Down
Loading