Skip to content

Conversation

mofeing
Copy link
Collaborator

@mofeing mofeing commented Jul 3, 2025

We also should rename promote_traced_type but not sure if to promote_transmute_type or promote_transmuted_type.

@mofeing mofeing assigned wsmoses and unassigned wsmoses Jul 3, 2025
@mofeing mofeing requested a review from wsmoses July 3, 2025 11:03
@mofeing mofeing marked this pull request as draft July 3, 2025 12:26
@mofeing mofeing marked this pull request as ready for review July 3, 2025 14:50
@Pangoraw
Copy link
Collaborator

Pangoraw commented Jul 8, 2025

Can be a good use case for @deprecate. it would require moving the implementation to the new name and marking the old name with it.

@mofeing
Copy link
Collaborator Author

mofeing commented Jul 8, 2025

Can be a good use case for @deprecate. it would require moving the implementation to the new name and marking the old name with it.

The main reason why I haven't marked like that yet is because it may trigger a lot of depwarn messages right? Also, we cannot just use @deprecate because it will break specializations of make_tracer and traced_type_inner. We agreed to put these names and finally rename everything on the 0.3 release.

@Pangoraw
Copy link
Collaborator

Pangoraw commented Jul 8, 2025

As of Julia 1.5, functions defined by @deprecate do not print warning when julia is run without the --depwarn=yes flag set, as the default value of --depwarn option is no. The warnings are printed from tests run by Pkg.test().

this is the current state of things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants