feat: disassemble IFRT array into shards for serialization #1136
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Apr 6, 2025
avik-pal
force-pushed
the
ap/save_sharded_array
branch
2 times, most recently
from
92c4775 to
12691ff
Compare
glwagner
reviewed
Apr 7, 2025
| return [ | ||
| mapping_unpadded[i] for | ||
| i in 1:length(mapping_unpadded) if isassigned(mapping_unpadded, i) | ||
| ] |
There was a problem hiding this comment.
in the typical case that we have one array per process, we'll use something like
adev = Sharding.disassemble_into_single_device_arrays(a)
acpu = Array(adev[1])is that right?
There was a problem hiding this comment.
I dont think you will have 1 array per process. If you have 4 gpus per node based on our current run configurations, you will have 4 arrays per process.
to get the arrays you can do [s => Array(x) for (s, x) in ret_val]. s is basically telling you the slice of this array as part of the global array
There was a problem hiding this comment.
ah right ok thanks. per device, not per process
avik-pal
force-pushed
the
ap/save_sharded_array
branch
from
1a6249c to
57f4b4f
Compare
avik-pal
force-pushed
the
ap/save_sharded_array
branch
from
57f4b4f to
78aad81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.