Skip to content

ProbProg: Making trace an operand #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 86 commits into from
Aug 3, 2025
Merged

ProbProg: Making trace an operand #2363

merged 86 commits into from
Aug 3, 2025

Conversation

@sbrantq
Copy link
Member

@sbrantq sbrantq commented Jun 27, 2025 •
edited
Loading

  • A complete overhaul of ProbProg ODS and MLIR pass to make execution traces and constraint dicts (for now both working with Julia frontend) MLIR operands instead of attributes (which are very limited)
  • Enforced the calling convention that the 0th input/output operands of sample, simulate, generate ops must be (updated) RNG states.

sbrantq added 30 commits March 21, 2025 16:27
@sbrantq
separating out things
ebfbc03
@sbrantq
Add trace op
a479207
@sbrantq
clean up
bdd5957
@sbrantq
format
bcb6943
@sbrantq
rename
a436e25
@sbrantq
improve op
962568c
@sbrantq
improve test
716f30c
@sbrantq
Force logpdf func
be7a16b
@sbrantq
verify logpdf
b9d724b
@sbrantq
save
3ed105e
@sbrantq
simulate op
402caa9
@sbrantq
Merge branch 'main' of https://github.com/EnzymeAD/Enzyme into sampleop
8eb4eba
@sbrantq
suppress
a77b141
@sbrantq
fix
094327a
@sbrantq
condOp
ded5990
@sbrantq
Bayesian linear regression test
e3953aa
@sbrantq
Refactor stuff to use probprogutils
b70a6e6
@sbrantq
scf test (not working)
38f2b85
@sbrantq
remove logpdf
971da10
@sbrantq
direct pp model call
dd01e86
@sbrantq
Merge branch 'main' of https://github.com/EnzymeAD/Enzyme into sampleop
fd5084b
@sbrantq
fix build
447201e
@sbrantq
fix up
8333afc
@sbrantq
merge
6511a8d
@sbrantq
Merge branch 'main' of https://github.com/EnzymeAD/Enzyme into sampleop
36691e5
@sbrantq
simple generate test
707b882
@sbrantq
remove call test
0128e0f
@sbrantq
Merge branch 'main' of https://github.com/EnzymeAD/Enzyme into sampleop
4107d2e
@sbrantq
undo merge hack
94c684f
@sbrantq
clean up and fix roundtrip test
03f3034
@sbrantq sbrantq requested a review from wsmoses July 11, 2025 16:49
@sbrantq sbrantq changed the base branch from probprog-simulate to main July 11, 2025 16:59
@sbrantq sbrantq marked this pull request as ready for review July 11, 2025 16:59
wsmoses
wsmoses reviewed Jul 11, 2025
View reviewed changes
@sbrantq sbrantq requested a review from wsmoses July 18, 2025 01:17
@sbrantq sbrantq added this pull request to the merge queue Aug 3, 2025
Merged via the queue into main with commit d48bb60 Aug 3, 2025
24 checks passed
This was referenced Aug 3, 2025
Closed
Closed
@giordano giordano deleted the probprog-trace-operand branch September 18, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbrantq @wsmoses