Skip to content

[MLIR] Forward Mode arg conversion for dup -> const #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 2, 2025
Merged

[MLIR] Forward Mode arg conversion for dup -> const #2349

merged 8 commits into from
Aug 2, 2025

Conversation

@vimarsh6739
Copy link
Member

@vimarsh6739 vimarsh6739 commented Jun 16, 2025 •
edited
Loading

@vimarsh6739 vimarsh6739 added forward mode Forward Mode AD reverse mode Reverse Mode AD mlir labels Jun 16, 2025
@vimarsh6739 vimarsh6739 changed the title [DO NOT MERGE] Input activity canonicalizations input activity canonicalization (dup to const) Jun 19, 2025
@vimarsh6739 vimarsh6739 requested a review from wsmoses June 19, 2025 00:10
@vimarsh6739 vimarsh6739 removed the reverse mode Reverse Mode AD label Jun 19, 2025
@vimarsh6739 vimarsh6739 marked this pull request as ready for review June 19, 2025 00:28
@vimarsh6739 vimarsh6739 changed the title input activity canonicalization (dup to const) [MLIR] Forward Mode arg conversion for dup -> const Jun 19, 2025
wsmoses
wsmoses reviewed Jun 20, 2025
View reviewed changes
@vimarsh6739 vimarsh6739 enabled auto-merge August 2, 2025 00:28
@vimarsh6739
Copy link
Member Author

vimarsh6739 commented Aug 2, 2025

@wsmoses can you approve this

wsmoses
wsmoses reviewed Aug 2, 2025
View reviewed changes
wsmoses
wsmoses approved these changes Aug 2, 2025
View reviewed changes
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo comment about isZero interface return type

@wsmoses
Copy link
Member

wsmoses commented Aug 2, 2025

also errors here are genuine:

/__w/Enzyme/Enzyme/Enzyme/enzyme/Enzyme/MLIR/Dialect/Ops.cpp:201:10: error: variable 'retActivity' set but not used [-Werror=unused-but-set-variable]
  201 |     auto retActivity = uop.getRetActivity();
      |          ^~~~~~~~~~~

@vimarsh6739
Copy link
Member Author

vimarsh6739 commented Aug 2, 2025 •
edited
Loading

Ah that I can remove (on a side note, it might be a good idea to add that to bazelrc)

vimarsh6739 and others added 8 commits August 2, 2025 00:55
@vimarsh6739
Added skeleton impl
581504f
@vimarsh6739
remove return activity stuff
658b754 
Signed-off-by: Vimarsh Sathia <vsathia2@illinois.edu>
@vimarsh6739
impl dup to const
b740c20 
Signed-off-by: Vimarsh Sathia <vimarsh.sathia@gmail.com>
@vimarsh6739
Some cleanup
132563b 
Signed-off-by: Vimarsh Sathia <vimarsh.sathia@gmail.com>
@vimarsh6739
use isZero
c253cc2
@vimarsh6739
fmt
82a40c7
@vimarsh6739
make format happy
d5e2fe8
@vimarsh6739
remove unused retactivity
9c9860c
@vimarsh6739 vimarsh6739 added this pull request to the merge queue Aug 2, 2025
Merged via the queue into main with commit c3da306 Aug 2, 2025
29 of 30 checks passed
@giordano giordano deleted the inpfwdactivityopt branch September 18, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees

No one assigned

Labels

forward mode Forward Mode AD mlir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vimarsh6739 @wsmoses